Skip to content

Increase adapter reuse + consistent reuse pattern - #281

Merged
arielge merged 3 commits into
mainfrom
reuse
Aug 9, 2026
Merged

Increase adapter reuse + consistent reuse pattern#281
arielge merged 3 commits into
mainfrom
reuse

Conversation

@arielge

@arielge arielge commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@arielge arielge changed the title Increase granite reuse + consistent reuse pattern Increase adapter reuse + consistent reuse pattern Aug 4, 2026
@arielge
arielge marked this pull request as ready for review August 4, 2026 13:20
@arielge
arielge requested review from BenjSz and kiszk as code owners August 4, 2026 13:20
Comment thread tests/spyre/test_vlm_e2e_spyre.py
@arielge
arielge force-pushed the reuse branch 3 times, most recently from f73c60a to 49f41a6 Compare August 6, 2026 12:53
arielge added 3 commits August 9, 2026 11:50
Signed-off-by: Ariel Gera <ariel.gera1@ibm.com>
Signed-off-by: Ariel Gera <ariel.gera1@ibm.com>
Signed-off-by: Ariel Gera <ariel.gera1@ibm.com>

@BenjSz BenjSz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arielge
arielge enabled auto-merge August 9, 2026 08:51
@arielge
arielge added this pull request to the merge queue Aug 9, 2026
@spyre-ci

spyre-ci Bot commented Aug 9, 2026

Copy link
Copy Markdown

❌ merge-queue-integration: failure

:warning: orch *trigger-pr-validation* — *yellow* · arches amd64 · fp amd64=05fef83b
L0 deeptools                amd64 ❌
L1 flex                     amd64 ⛔
L2 aiu-toolbox/ibm-aiu-toolbox-e2e amd64 ⛔
L2 spyre-comms              amd64 ⛔
L3 spyre-backend/spyre-backend-dev amd64 ⛔
L4 torch-spyre/torch-spyre-dev amd64 ⛔
L5 hf-adapters/hf-adapters-dev amd64 ⛔
L6 spyre-inference/spyre-inference-dev amd64 ⛔

Merged via the queue into main with commit fd4c70d Aug 9, 2026
79 checks passed
@arielge
arielge deleted the reuse branch August 9, 2026 10:45
assaftibm pushed a commit that referenced this pull request Aug 10, 2026
* Increase granite reuse + consistent reuse pattern

Signed-off-by: Ariel Gera <ariel.gera1@ibm.com>

* Simplify roberta adapter

Signed-off-by: Ariel Gera <ariel.gera1@ibm.com>

* another ignore for mypy

Signed-off-by: Ariel Gera <ariel.gera1@ibm.com>

---------

Signed-off-by: Ariel Gera <ariel.gera1@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants